Params: Add do_not_log to param block open/close#558
Merged
Conversation
This patch adds `do_not_log` to `openParameterBlock`, to prevent logging of `BLOCK%` `%BLOCK` entry and exit calls. The argument was not added to `closeParameterBlock`, since this state can be tracked inside the `block` with a new `log_access` field in `parameter_block`. This flag does not extend to parameters within the block, since (as far as I know) there is no way for a `get_param` to know if it is within a block or not. Even if it could know this, there would need to be some careful handling of nested blocks. The potential block/parameter inconsistency should be supported at some point, but for now it is the user's responsibility to consistently apply `do_not_log` to blocks and its contents.
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## dev/gfdl #558 +/- ##
============================================
- Coverage 37.19% 37.19% -0.01%
============================================
Files 271 271
Lines 80346 80351 +5
Branches 14982 14985 +3
============================================
+ Hits 29887 29888 +1
- Misses 44902 44904 +2
- Partials 5557 5559 +2 ☔ View full report in Codecov by Sentry. |
Hallberg-NOAA
approved these changes
Jan 29, 2024
Member
Hallberg-NOAA
left a comment
Hallberg-NOAA
left a comment
There was a problem hiding this comment.
Thank you for this valuable addition to the MOM6 code.
Member
Author
|
Gaea regression: https://gitlab.gfdl.noaa.gov/ogrp/MOM6/-/pipelines/22093 ✔️ |
Closed
This was referenced May 16, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch adds
do_not_logtoopenParameterBlock, to prevent logging ofBLOCK%%BLOCKentry and exit calls.The argument was not added to
closeParameterBlock, since this state can be tracked inside theblockwith a newlog_accessfield inparameter_block.This flag does not extend to parameters within the block, since (as far as I know) there is no way for a
get_paramto know if it is within a block or not. Even if it could know this, there would need to be some careful handling of nested blocks.The potential block/parameter inconsistency should be supported at some point, but for now it is the user's responsibility to consistently apply
do_not_logto blocks and its contents.