+tracer_Z_init can rescale tracers#555
Merged
marshallward merged 2 commits intoFeb 21, 2024
Merged
Conversation
Added the new optional scale argument to tracer_Z_init to allow the units of the tracers that it initializes from a z-space file to be rescaled, similarly to what is already done in tracer_z_init_array. This also required the addition of the new missing_scale argument to the private routine read_Z_edges to specify how the missing values are rescaled. Comments were also added or modified describing 28 real variables or their units in this module. By default all answers are bitwise identical, but when this new option is exercised, answers could change at roundoff for some non-Boussinesq cases.
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## dev/gfdl #555 +/- ##
============================================
- Coverage 37.20% 37.20% -0.01%
============================================
Files 271 271
Lines 80456 80457 +1
Branches 15001 15002 +1
============================================
Hits 29932 29932
- Misses 44957 44958 +1
Partials 5567 5567 ☔ View full report in Codecov by Sentry. |
marshallward
approved these changes
Feb 20, 2024
Member
|
Gaea regression: https://gitlab.gfdl.noaa.gov/ogrp/MOM6/-/pipelines/22390 ✔️ |
This was referenced May 16, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added the new optional
scaleargument totracer_Z_init()to allow the units of the tracers that it initializes from a z-space file to be rescaled, similarly to what is already done intracer_z_init_array(). This also required the addition of the newmissing_scaleargument to the private routineread_Z_edges()to specify how the missing values are rescaled. Comments were also added or modified describing 28 real variables or their units in this module. By default all answers are bitwise identical, but when this new option is exercised, answers could change at roundoff for some non-Boussinesq cases.