change target to pointer and check for association#529
Closed
raphaeldussin wants to merge 5 commits into
Closed
Conversation
Member
|
This looks like it should resolve the issue raised by @gustavo-marques and @alperaltuntas. @raphaeldussin Would you mind rebasing this against |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## dev-gfdl-main-candidate-2023-11-13 #529 +/- ##
======================================================================
+ Coverage 37.45% 37.48% +0.03%
======================================================================
Files 270 271 +1
Lines 79765 79535 -230
Branches 14831 14819 -12
======================================================================
- Hits 29879 29817 -62
+ Misses 44350 44176 -174
- Partials 5536 5542 +6 ☔ View full report in Codecov by Sentry. |
- Added a base class in MOM_EOS_base_type.F90
- All EOS modules now extend this base class
- This reduces replicated code between the EOS modules
- All existing APIs in MOM_EOS now avoid branching for the type of
EOS and ultimately pass through to a low-level elemental function
implementation of the actual EOS
- Added a new elemental function exposed by MOM_EOS
(currently not used in the main model)
- There is a speed up over the previous form of EOS due to the
reduced branching
- For some functions, a local implementation of the base class member is
needed to gain performance. I deliberately did not implement this
optimization for UNESCO or Jackett06 so that the generic implementation
of the base class is utilized and we have code coverage.
- Added rules to .testing/Makefile to invoke build.timing, run.timing for the "target" code checked out for regression tests - Appended to existing GH "perfmon" workflow
Added or corrected the units in comments describing about 200 real variables in MOM_hor_bnd_diffusion and MOM_neutral_diffusion, and corrected spelling errors or other issues in about another 20 comments. Only comments are changed and all answers are bitwise identical.
Fix unpaired parentheses in the format statement used in an error message about OBC segment data not being on the supergrid. All answers are bitwise identical, but there is one less compile-time warning.
raphaeldussin
force-pushed
the
fix_inttide_pointer
branch
from
cbcadaf to
8c03cbb
Compare
raphaeldussin
changed the base branch from
dev/gfdl
to
dev-gfdl-main-candidate-2023-11-13
Member
|
@alperaltuntas Can you check this if PR fixes the issue you saw? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
attempting to solve problem raised by @gustavo-marques in mom-ocean#1616