Skip to content

Add units to comments in MOM_neutral_diffusion#523

Merged
marshallward merged 2 commits into
NOAA-GFDL:dev/gfdlfrom
Hallberg-NOAA:tracer_diffusion_units
Nov 23, 2023
Merged

Add units to comments in MOM_neutral_diffusion#523
marshallward merged 2 commits into
NOAA-GFDL:dev/gfdlfrom
Hallberg-NOAA:tracer_diffusion_units

Conversation

@Hallberg-NOAA
Copy link
Copy Markdown
Member

Added or corrected the units in comments describing about 200 real variables in MOM_hor_bnd_diffusion and MOM_neutral_diffusion, and corrected spelling errors or other issues in about another 20 comments. Only comments are changed and all answers are bitwise identical.

  Added or corrected the units in comments describing about 200 real variables
in MOM_hor_bnd_diffusion and MOM_neutral_diffusion, and corrected spelling
errors or other issues in about another 20 comments.  Only comments are changed
and all answers are bitwise identical.
@Hallberg-NOAA Hallberg-NOAA added the documentation Improvements or additions to documentation label Nov 16, 2023
@codecov
Copy link
Copy Markdown

codecov Bot commented Nov 16, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (7cc191a) 37.49% compared to head (d0d57e5) 37.55%.

Files Patch % Lines
src/tracer/MOM_hor_bnd_diffusion.F90 71.42% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##           dev/gfdl     #523      +/-   ##
============================================
+ Coverage     37.49%   37.55%   +0.06%     
============================================
  Files           271      271              
  Lines         79533    79407     -126     
  Branches      14816    14795      -21     
============================================
+ Hits          29818    29819       +1     
+ Misses        44175    44049     -126     
+ Partials       5540     5539       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Copy Markdown
Member

@gustavo-marques gustavo-marques left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for these fixes!

Copy link
Copy Markdown

@MJHarrison-GFDL MJHarrison-GFDL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@marshallward
Copy link
Copy Markdown
Member

Gaea regression: https://gitlab.gfdl.noaa.gov/ogrp/MOM6/-/pipelines/21437 ✔️

@marshallward marshallward merged commit 34b880f into NOAA-GFDL:dev/gfdl Nov 23, 2023
@Hallberg-NOAA Hallberg-NOAA deleted the tracer_diffusion_units branch May 10, 2024 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants