Option to homogenize forces and fluxes#51
Conversation
- Adds functions to do global averages on U and V grids in MOM_spatial_means - Adds functionality to average all forcing and fluxes fields in MOM_forcing_types - Adds flag to average all forcing and fluxes in MOM.F90 - This new feature is primarily for running in single column like configurations with the coupler, which requires perfectly equal forcing across all cells.
- Adds in irho0 and sqrt that were missing in homogenize mech forcing.
- Correct issues in global_area_mean_u and global_area_mean_v to work with symmetric and rotated grids. - Add options to compute mean ustar or compute ustar from mean tau. - Add subroutines to replace averaging blocks in MOM_forcing_type.
- Move a division and reformat alignment in MOM_spatial_means.F90. - Remove a unused parameter in MOM_forcing_type.F90 - Reformat misalignment of an "if-block" in MOM_forcing_type.F90
…r/bgr/Homogenize_forces_and_fluxes
- netSalt has been removed so no longer needs homogenized in the fluxes.
Codecov Report
@@ Coverage Diff @@
## dev/gfdl #51 +/- ##
============================================
- Coverage 28.91% 28.85% -0.07%
============================================
Files 242 242
Lines 71260 71422 +162
============================================
+ Hits 20606 20609 +3
- Misses 50654 50813 +159
Continue to review full report at Codecov.
|
Hallberg-NOAA
left a comment
Hallberg-NOAA
left a comment
There was a problem hiding this comment.
I have looked through these changes thoroughly, and I agree that they appear to be correct and thoughtfully implemented. I am approving these changes, and they should be merged in as soon as they have passed the TC and pipeline testing.
|
This PR has passed TC testing and pipeline testing at https://gitlab.gfdl.noaa.gov/ogrp/MOM6/-/pipelines/14473, but there are new entries in the MOM_parameter_doc.all files, which will have to be updated. |
2 participants
This is the continuation of github.com/mom-ocean/MOM6/pull/1541, which was closed when migrating from NOAA-GFDL to mom-ocean. There are a couple extra changes since that PR was closed, including updating code, updating the homogenization routine to account for updated code, and a typo on the mask on U points.