Fixes an uninitialized logical in FMS_cap#50
Merged
marshallward merged 2 commits intoDec 26, 2021
Conversation
Member
adcroft
commented
Dec 22, 2021
adcroft
commented
- A do_not_log depends on a logical that is only set conditionally. This initializes that logical when the corresponding parameter is not being read.
- Unfortunately, this change MOM_parameter_doc.all for the coupled models. The .all pipeline uses the gnu compiler which was initializing this logical as .true. and thus logging the new parameter when it should not have been. Intel and PGI were initializing with .false.
- A do_not_log depends on a logical that is only set conditionally. This initializes that logical when the corresponding parameter is not being read. - Unfortunately, this change MOM_parameter_doc.all for the coupled models. The .all pipeline uses the gnu compiler which was initializing this logical as .true. and thus logging the new parameter when it should not have been. Intel and PGI were initializing with .false.
Codecov Report
@@ Coverage Diff @@
## dev/gfdl #50 +/- ##
=========================================
Coverage 28.96% 28.96%
=========================================
Files 242 242
Lines 71324 71324
=========================================
Hits 20660 20660
Misses 50664 50664 Continue to review full report at Codecov.
|
Member
|
Gaea regression: https://gitlab.gfdl.noaa.gov/ogrp/MOM6/-/pipelines/14425 ✔️ Reverts the parameter change due to the volatile logical initialization. |
marshallward
approved these changes
Dec 26, 2021
This was referenced Jan 29, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.