makedep: Module dependency in nested includes#489
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## dev/gfdl #489 +/- ##
=========================================
Coverage 37.84% 37.84%
=========================================
Files 270 270
Lines 78231 78231
Branches 14477 14477
=========================================
+ Hits 29606 29607 +1
+ Misses 43238 43236 -2
- Partials 5387 5388 +1 see 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
marshallward
force-pushed
the
makedep_nested_mod
branch
2 times, most recently
from
7817a0a to
a0798d5
Compare
adcroft
approved these changes
Oct 5, 2023
Nested includes are tracked for the purpose of include flags (-I), but not with respect to the content within those files. This patch tracks the module usage statements (`use ...`) inside of any include files and adds them to the Makefile rules of the top-level file. This was implemented within the `nested_inc` function by adding a new argument.
adcroft
force-pushed
the
makedep_nested_mod
branch
from
a0798d5 to
13a1e7e
Compare
This was referenced Nov 13, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Nested includes are tracked for the purpose of include flags (-I), but not with respect to the content within those files. This patch tracks the module usage statements (
use ...) inside of any include files and adds them to the Makefile rules of the top-level file.This was implemented within the
nested_incfunction by adding a new argument.