Ice-shelf solo driver and MISMIP+ updates#471
Conversation
Codecov Report
@@ Coverage Diff @@
## dev/gfdl #471 +/- ##
============================================
- Coverage 37.83% 37.79% -0.05%
============================================
Files 270 270
Lines 78346 78375 +29
Branches 14502 14533 +31
============================================
- Hits 29643 29622 -21
- Misses 43296 43318 +22
- Partials 5407 5435 +28
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
8a66adc to
9de6ce7
Compare
518269c to
00f8a4e
Compare
Hallberg-NOAA
left a comment
There was a problem hiding this comment.
I do not understand why we need a separate solo_ice_shelf_diag_mediator_end() routine in MOM_diag_mediator.F90 that is distict from diag_mediator_end(). They appear to me to take the same arguments and do the same thing, perhaps with a little error checking. Given that they are so similar, why not add the safety checks to diag_mediator_end()?
Also, the capability being added with the new runtime parameter SAVE_BOTH_RESTARTS could already have been obtained by setting RESTART_CONTROL=3. The new parameter may be more explicit, but it does add to the list of parameters without actually adding any new capabilities.
|
I revised the PR as suggested by @Hallberg-NOAA . I added safety checks to |
Hallberg-NOAA
left a comment
There was a problem hiding this comment.
This set of code changes looks reasonable to me.
-Several edits to the ice shelf solo driver so that it works with the rest of the current MOM6 -Added capability to initialize a surface mass balance (SMB) that is held contstant over time when running from the ice-shelf solo driver (see new subroutine initialize_ice_SMB). This is required for MISMIP+. A constant SMB can also be used from the MOM driver for coupled ice-shelf/ocean experiments (e.g. MISOMIP). -The new, constant SMB is passed into solo_step_ice_shelf, where change_thickness_using_precip is called -Added capability to save both non-time-stamped and time-stamped restart files when using the ice shelf solo driver. This is useful for debugging. -slight reorganization to when ice shelf post_data calls are made
…ice shelf solo-driver, which now calls it instead of (now removed) solo_ice_shelf_diag_mediator_end() routine. Removed the runtime parameter SAVE_BOTH_RESTARTS from the ice shelf solo-driver, which is no longer needed.
5ca83c6 to
11a2b25
Compare
-Several edits to the ice shelf solo driver so that it works with the rest of the current MOM6
-Added capability to initialize a surface mass balance (SMB) that is held contstant over time when running from the ice-shelf solo driver (see new subroutine initialize_ice_SMB). This is required for MISMIP+. A constant SMB can also be used from the MOM driver for coupled ice-shelf/ocean experiments (e.g. MISOMIP).
-The new, constant SMB is passed into solo_step_ice_shelf, where change_thickness_using_precip is called
-Added capability to save both non-time-stamped and time-stamped restart files when using the ice shelf solo driver. This is useful for debugging.
-slight reorganization to when ice shelf post_data calls are made