Bugfix in MLE for reproducible restarts with USE_BODNER23 = True#465
Merged
Conversation
breichl
commented
Aug 21, 2023
breichl
commented
- Update for missing halo update of field wpup_filtered in MOM_mixed_layer_restrat.F90 during initialization.
- The missing halo update caused the model to diverge when running from restart files.
- With the halo update the model now reproduces from restart files.
- Update for missing halo update of field wpup_filtered in MOM_mixed_layer_restrat.F90 during initialization. - The missing halo update caused the model to diverge when running from restart files. - With the halo update the model now reproduces from restart files.
adcroft
approved these changes
Aug 21, 2023
Codecov Report
@@ Coverage Diff @@
## dev/gfdl #465 +/- ##
=========================================
Coverage 38.04% 38.05%
=========================================
Files 269 269
Lines 77417 77418 +1
Branches 14300 14301 +1
=========================================
+ Hits 29457 29461 +4
+ Misses 42617 42613 -4
- Partials 5343 5344 +1
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Member
|
Gaea regression: https://gitlab.gfdl.noaa.gov/ogrp/MOM6/-/pipelines/20376 ✔️ |
This was referenced Nov 13, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.