implement restart for internal tides#463
Conversation
* add a call to register restart diabatic in MOM * register restart diabatic call register restart internal tides * internal tides restart uses the extra_axes optional argument * support for extra_axes added to MOM_restart/MOM_io
Codecov Report
@@ Coverage Diff @@
## dev/gfdl #463 +/- ##
============================================
- Coverage 38.04% 38.01% -0.03%
============================================
Files 270 270
Lines 77637 77764 +127
Branches 14285 14320 +35
============================================
+ Hits 29538 29564 +26
- Misses 42783 42876 +93
- Partials 5316 5324 +8
... and 3 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more 📢 Have feedback on the report? Share it here. |
* passes global_file optional arg to allow reading in parallel restart files
vertical modes >= 6 do not propagate hence there is no need for dynamic array size on this dimension
marshallward
left a comment
There was a problem hiding this comment.
Extending restart registration to set the global_file flag seems to me to be a very good solution to me for supporting potentially domain-decomposed 4d restarts.
It does revert some of the effort to transition control structures from pointers to stack variable, but this can be handled for now.
I have included some minor comments which should finalize this PR, and we can merge it ASAP.
3b882ff to
b7852ce
Compare
b7852ce to
5405c3b
Compare
marshallward
left a comment
There was a problem hiding this comment.
The updated version looks like a very good implementation to support 4d restart fields from the internal tide module, and allows for extended support in the future.
Uh oh!
There was an error while loading. Please reload this page.