Bugfix - calculate density integrals in ALE mode w/ pressure_reconstr…#45
Merged
marshallward merged 3 commits intoDec 23, 2021
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## dev/gfdl #45 +/- ##
=========================================
Coverage 28.96% 28.96%
=========================================
Files 242 242
Lines 71324 71324
=========================================
Hits 20660 20660
Misses 50664 50664
Continue to review full report at Codecov.
|
Hallberg-NOAA
approved these changes
Dec 17, 2021
Member
Hallberg-NOAA
left a comment
Hallberg-NOAA
left a comment
There was a problem hiding this comment.
This is a decisive, insightful, and succinct bug fix. Well done!
(My only minor critique here is that at some point the ".gt." in these expressions is prone to being replaced in a semi-automated sweep with the more succinct ">" used elsewhere in the MOM6 code.)
Replace `.gt.` with `>`
Member
|
Gaea regression: https://gitlab.gfdl.noaa.gov/ogrp/MOM6/-/pipelines/14420 ✔️ |
This was referenced Jan 29, 2022
Hallberg-NOAA
added
answer-changing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix missing call to calculate density integrals in ALE mode with PRESSURE_RECONSTRUCTION_SCHEME=0