Skip to content

Refactor rescaling of CFC_cap flux diagnostics#442

Merged
marshallward merged 2 commits into
NOAA-GFDL:dev/gfdlfrom
Hallberg-NOAA:nonBous_CFC_cap
Aug 16, 2023
Merged

Refactor rescaling of CFC_cap flux diagnostics#442
marshallward merged 2 commits into
NOAA-GFDL:dev/gfdlfrom
Hallberg-NOAA:nonBous_CFC_cap

Conversation

@Hallberg-NOAA
Copy link
Copy Markdown
Member

Rescaled CFC flux diagnostics in the CFC cap via a conversion factor in their register diag_field calls, rather than by doing array syntax math in their post_data calls. All answers are bitwise identical.

  Rescaled CFC flux diagnostics in the CFC cap via a conversion factor in their
register diag_field calls, rather than by doing array syntax math in their
post_data calls.  All answers are bitwise identical.
@Hallberg-NOAA Hallberg-NOAA added the refactor Code cleanup with no changes in functionality or results label Aug 6, 2023
@codecov
Copy link
Copy Markdown

codecov Bot commented Aug 6, 2023

Codecov Report

Merging #442 (209a6b8) into dev/gfdl (d223f25) will increase coverage by 0.00%.
The diff coverage is 0.00%.

❗ Current head 209a6b8 differs from pull request most recent head 5cb3210. Consider uploading reports for the commit 5cb3210 to get more accurate results

@@            Coverage Diff            @@
##           dev/gfdl     #442   +/-   ##
=========================================
  Coverage     38.06%   38.06%           
=========================================
  Files           269      269           
  Lines         77234    77231    -3     
  Branches      14266    14266           
=========================================
+ Hits          29398    29400    +2     
+ Misses        42508    42504    -4     
+ Partials       5328     5327    -1     
Files Changed Coverage Δ
src/tracer/MOM_CFC_cap.F90 18.33% <0.00%> (+0.30%) ⬆️

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Copy Markdown
Member

@marshallward marshallward left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Straightforward change.

@marshallward
Copy link
Copy Markdown
Member

Gaea regression: https://gitlab.gfdl.noaa.gov/ogrp/MOM6/-/pipelines/20324 ✔️

@marshallward marshallward merged commit d16f343 into NOAA-GFDL:dev/gfdl Aug 16, 2023
@Hallberg-NOAA Hallberg-NOAA deleted the nonBous_CFC_cap branch September 27, 2023 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

refactor Code cleanup with no changes in functionality or results

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants