Skip to content

Adding a knob for strength of brine plume mixing.#434

Merged
marshallward merged 1 commit into
NOAA-GFDL:dev/gfdlfrom
ESMG:plume_knob
Aug 10, 2023
Merged

Adding a knob for strength of brine plume mixing.#434
marshallward merged 1 commit into
NOAA-GFDL:dev/gfdlfrom
ESMG:plume_knob

Conversation

@kshedstrom
Copy link
Copy Markdown

This gives a tuning knob for the amount of brine which gets mixed down by the brine plume parameterization.

@codecov
Copy link
Copy Markdown

codecov Bot commented Aug 4, 2023

Codecov Report

Merging #434 (1268bff) into dev/gfdl (fd31e01) will decrease coverage by 0.01%.
The diff coverage is 33.33%.

❗ Current head 1268bff differs from pull request most recent head 4af8e29. Consider uploading reports for the commit 4af8e29 to get more accurate results

@@             Coverage Diff              @@
##           dev/gfdl     #434      +/-   ##
============================================
- Coverage     38.07%   38.07%   -0.01%     
============================================
  Files           269      269              
  Lines         76957    76958       +1     
  Branches      14204    14204              
============================================
  Hits          29305    29305              
  Misses        42340    42340              
- Partials       5312     5313       +1     
Files Changed Coverage Δ
...rc/parameterizations/vertical/MOM_diabatic_aux.F90 59.71% <33.33%> (+0.05%) ⬆️

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Hallberg-NOAA Hallberg-NOAA added the Parameter change Input parameter changes (addition, removal, or description) label Aug 5, 2023
Copy link
Copy Markdown
Member

@Hallberg-NOAA Hallberg-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This simple addition seems very sensible.

@marshallward
Copy link
Copy Markdown
Member

Gaea regression: https://gitlab.gfdl.noaa.gov/ogrp/MOM6/-/pipelines/20224 ✔️

@marshallward marshallward merged commit 648012e into NOAA-GFDL:dev/gfdl Aug 10, 2023
@kshedstrom kshedstrom deleted the plume_knob branch November 10, 2023 23:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Parameter change Input parameter changes (addition, removal, or description)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants