+wave_speed arg mono_N2_depth in thickness units#424
Merged
marshallward merged 3 commits intoJul 26, 2023
Conversation
Hallberg-NOAA
added
the
refactor
Changed the units of the optional mono_N2_depth argument to wave_speed, wave_speed_init and wave_speed_set_param in thickness units instead of height units. Accordingly, the units of one element each in the diagnostics_CS and wave_speed_CS and a local variable in VarMix_init are also changed to thickness units. The unit descriptions of some comments describing diagnostics were also amended to also describe the non-Boussinesq versions. Because this is essentially just changing when the unit conversion occurs, all answers are bitwise identical, but there are changes to the units of an optional argument in 3 publicly visible routines.
Hallberg-NOAA
force-pushed
the
mono_N2_depth_units
branch
from
012c9c1 to
60089b3
Compare
Codecov Report
@@ Coverage Diff @@
## dev/gfdl #424 +/- ##
============================================
- Coverage 38.15% 38.15% -0.01%
============================================
Files 269 269
Lines 76737 76742 +5
Branches 14119 14122 +3
============================================
Hits 29278 29278
- Misses 42184 42189 +5
Partials 5275 5275
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
raphaeldussin
left a comment
raphaeldussin
left a comment
There was a problem hiding this comment.
I mostly agree with the proposed changes. I think some variables may need to be changes to thickness units.
raphaeldussin
approved these changes
Jul 25, 2023
marshallward
approved these changes
Jul 25, 2023
Member
marshallward
left a comment
marshallward
left a comment
There was a problem hiding this comment.
On behalf of @raphaeldussin
Member
|
Gaea regression: https://gitlab.gfdl.noaa.gov/ogrp/MOM6/-/pipelines/20040 ✔️ |
This was referenced Nov 13, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changed the units of the optional mono_N2_depth argument to wave_speed, wave_speed_init and wave_speed_set_param in thickness units instead of height units. Accordingly, the units of one element each in the diagnostics_CS and wave_speed_CS and a local variable in VarMix_init are also changed to thickness units. The unit descriptions of some comments describing diagnostics were also amended to also describe the non-Boussinesq versions. Because this is essentially just changing when the unit conversion occurs, all answers are bitwise identical, but there are changes to the units of an optional argument in 3 publicly visible routines.