+Rescale tides and ramp-up times#42
Merged
Merged
Conversation
Corrected the documentation of the units for 31 variables in various modules. All answers and output are bitwise identical.
Rescaled the dimensions of the tidal amplitudes and frequencies used internally in calc_tidal_forcing() and ramp-up times used by update_OBC_ramp() and updateCFLtruncationValue() for nearly complete dimensional consistency testing. New unit_scale_type arguments were added to 5 routines, in the case of calc_tidal_forcing() replacing a previous optional argument that was always being used. One overly short internal variable, "N", was renamed "nodelon" to make its purpose clearer and easier to search for. All answers are bitwise identical, but there are changes to the argument lists of 5 routines.
Codecov Report
@@ Coverage Diff @@
## dev/gfdl #42 +/- ##
=========================================
Coverage 28.95% 28.96%
=========================================
Files 240 240
Lines 71217 71222 +5
=========================================
+ Hits 20623 20627 +4
- Misses 50594 50595 +1
Continue to review full report at Codecov.
|
marshallward
approved these changes
Dec 20, 2021
Member
|
Gaea regression: https://gitlab.gfdl.noaa.gov/ogrp/MOM6/-/pipelines/14396 ✔️ |
This was referenced Jan 29, 2022
Hallberg-NOAA
added
documentation
uwagura
pushed a commit
to uwagura/MOM6
that referenced
this pull request
Nov 4, 2025
* port thickness_to_dz_3d to gpu (defensively) * add arg for turning off updates * comment to no_update arg * switch controls cpu/gpu work instead of data transfer * remove trailing spaces
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR rescaled the dimensions of the tidal amplitudes and frequencies used
internally in calc_tidal_forcing() and ramp-up times used by update_OBC_ramp()
and updateCFLtruncationValue() for nearly complete dimensional consistency
testing. New unit_scale_type arguments were added to 5 routines, in the case of
calc_tidal_forcing() replacing a previous optional argument that was always
being used. One overly short internal variable, "N", was renamed "nodelon" to
make its purpose clearer and easier to search for. The comments documenting an
additional 31 variables or their units were also corrected. All answers are
bitwise identical, but there are changes to the argument lists of 5 routines.
The commits in this PR include: