Converted warning about depth_list to a note#414
Conversation
The message that a file is being created was issued as a WARNING when we all agree it should really be a NOTE. Depth_list.nc is read if it is present to avoid recomputing a sorted list, but the absence of the file is not an error and does not warrant a warning. Changes: - Changed WARNING to NOTE. - Removed MOM_mesg from imports since it wasn't being used.
Codecov Report
@@ Coverage Diff @@
## dev/gfdl #414 +/- ##
============================================
- Coverage 38.17% 38.17% -0.01%
============================================
Files 269 269
Lines 76553 76553
Branches 14076 14076
============================================
- Hits 29226 29224 -2
- Misses 42077 42079 +2
Partials 5250 5250
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
I'm not even sure that this should be a NOTE. The file is always created if it doesn't exist, so I'm inclined to interpret it as normal output file. For comparison, we don't issue notes for the initial creation of |
Hallberg-NOAA
left a comment
Hallberg-NOAA
left a comment
There was a problem hiding this comment.
These changes seem sensible to me.
|
After discussion with @adcroft, we agreed there is no need for this message anymore and can be removed completely. |
|
I disagree. In the past, I have found this message to be useful when debugging certain activities related to the diagnosis of the model potential energy. We can reduce the verbosity level of this message if you would like, but it absolutely should not be removed altogether! |
|
Is it useful because a |
marshallward
force-pushed
the
less-noisy-messaging
branch
from
25dc0fe to
deecd54
Compare
|
I've reverted the removal. We'll take this as it is. |
|
Gaea regression: https://gitlab.gfdl.noaa.gov/ogrp/MOM6/-/pipelines/19950 ✔️ |
|
The large computational cost of constructing But it's not urgent, so we can come back around to this in the future, if we decide to further streamline the model output. |
3 participants
The message that a file is being created was issued as a WARNING when we all agree it should really be a NOTE. Depth_list.nc is read if it is present to avoid recomputing a sorted list, but the absence of the file is not an error and does not warrant a warning.
Changes: