+(*)Fix wave_speed_init mono_N2_depth bug#413
Merged
marshallward merged 2 commits intoJul 24, 2023
Merged
Conversation
Hallberg-NOAA
added
bug
Hallberg-NOAA
assigned
adcroft and
Hallberg-NOAA and unassigned
adcroft and
Hallberg-NOAA
Codecov Report
@@ Coverage Diff @@
## dev/gfdl #413 +/- ##
============================================
- Coverage 38.17% 38.17% -0.01%
============================================
Files 269 269
Lines 76553 76553
Branches 14076 14076
============================================
- Hits 29226 29225 -1
- Misses 42077 42079 +2
+ Partials 5250 5249 -1
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Hallberg-NOAA
force-pushed
the
wave_speed_init_mono_depth_bugfix
branch
from
5cbccda to
6206aea
Compare
adcroft
approved these changes
Jul 21, 2023
Member
adcroft
left a comment
adcroft
left a comment
There was a problem hiding this comment.
Seems right. Needs testing...
Fixed a bug in which wave_speed_init was effectively discarding any values of mono_N2_depth passed to it via the optional argument mono_N2_depth, but also changed the default value of RESOLN_N2_FILTER_DEPTH, which was previously being discarded, to disable the monotonization and replicate the previous results. There were also clarifying additions made to the description how to disable RESOLN_N2_FILTER_DEPTH. This will change some entries in MOM_parameter_doc files, and it will change solutions in cases that set RESOLN_N2_FILTER_DEPTH to a non-default value and have parameter settings that use the resolution function to scale their horizontal mixing. There are, however, no known active simulations where the answers are expected to change.
Hallberg-NOAA
force-pushed
the
wave_speed_init_mono_depth_bugfix
branch
from
6206aea to
ed0a9d1
Compare
Member
This was referenced Nov 13, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed a bug in which wave_speed_init was effectively discarding any values of mono_N2_depth passed to it via the optional argument mono_N2_depth, but also changed the default value of RESOLN_N2_FILTER_DEPTH, which was previously being discarded, to disable the monotonization and replicate the previous results. There were also clarifying additions made to the description how to disable RESOLN_N2_FILTER_DEPTH. This will change some entries in MOM_parameter_doc files, and it will change solutions in cases that set RESOLN_N2_FILTER_DEPTH to a non-default value and have parameter settings that use the resolution function to scale their horizontal mixing. There are, however, no known active simulations where the answers are expected to change.