Correct diagnostic coordinate interpolation scheme#411
Merged
marshallward merged 2 commits intoJul 24, 2023
Conversation
The interpolation scheme for state-dependent diagnostic coordinates was incorrectly registering as the same parameter as the main model. This meant it was never possible to change the interpolation scheme from the default (which was not the same as the main model). Fix registers the generated parameter name which was always computed but not used. A typical example of the generated parameter is "DIAG_COORD_INTERP_SCHEME_RHO2".
Codecov Report
@@ Coverage Diff @@
## dev/gfdl #411 +/- ##
============================================
- Coverage 38.17% 38.17% -0.01%
============================================
Files 269 269
Lines 76553 76553
Branches 14076 14076
============================================
- Hits 29227 29226 -1
- Misses 42076 42077 +1
Partials 5250 5250
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Hallberg-NOAA
approved these changes
Jul 20, 2023
Member
Hallberg-NOAA
left a comment
Hallberg-NOAA
left a comment
There was a problem hiding this comment.
This code change does seem to be actually doing what was originally intended here, and it should do a nice job of eliminating several warnings.
Hallberg-NOAA
added
the
Parameter change
Member
This was referenced Nov 13, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The interpolation scheme for state-dependent diagnostic coordinates was incorrectly registering as the same parameter as for the main model ("INTERPOLATION_SCHEME"). This meant it was never possible to change the diagnostics vertical interpolation scheme from the default (which was not the same as the main model).
This fix registers the generated parameter name which was always computed but not used. A typical example of the generated parameter is "DIAG_COORD_INTERP_SCHEME_RHO2".
Affects these doc files:
The fix removes one of the many warnings we've been ignoring for a long time.