+add h to drifters interface

[cspencerjones]

This commit brings the drifters interface up-to-date with the current version of the drifters package, which requires h (layer thickness) to calculate the vertical movement of particles. The interfaces in the code and in config_src/external are updated to pass this information to the drifters package.

[codecov]

Codecov Report

Merging #408 (2db108b) into dev/gfdl (147ddf1) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

❗ Current head 2db108b differs from pull request most recent head 1b1845a. Consider uploading reports for the commit 1b1845a to get more accurate results

@@             Coverage Diff              @@
##           dev/gfdl     #408      +/-   ##
============================================
- Coverage     38.15%   38.15%   -0.01%     
============================================
  Files           269      269              
  Lines         76667    76675       +8     
  Branches      14103    14105       +2     
============================================
  Hits          29254    29254              
- Misses        42146    42152       +6     
- Partials       5267     5269       +2     

Files Changed	Coverage Δ
config_src/external/drifters/MOM_particles.F90	0.00% <0.00%> (ø)
src/core/MOM.F90	50.97% <0.00%> (-0.13%)	⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[MJHarrison-GFDL]

The subroutine argument documentation needs unit and rescaling information, e.g. "layer thickness [H ~> m or kg m-2]" and "time [T ~> s]" .

[cspencerjones]

Thanks - is this ok? Or were you looking for something more?

[MJHarrison-GFDL]

Hi Spencer! You can look at other routines to template this. Layer thickness are denoted [H ~> m or kg m-2] , temperature is [C ~> degC], salt is [S ~> ppt], time is [T ~> s]. Sorry to be a nuisance here.

[marshallward]

Some other style comments:

• Indentation should be 2-space. I see many instances of 1-space, 3-space and 4-space. e.g.

      if (CS%use_particles) then
          call particles_to_z_space(CS%particles,h)
      endif
  

    if (CS%use_particles) then
       call particles_to_k_space(CS%particles,h)
    endif
  

• Commas should usually be followed by a space, e.g.

  subroutine particles_init(parts, Grid, Time, dt, u, v,h)
  

  use MOM_particles_mod,         only : particles_to_k_space,particles_to_z_space
  

  (Array indexing is an exception)

More than you could want to know at the style guide. As Matt said, sorry to be a nuisance.

[cspencerjones]

Thanks @marshallward and @MJHarrison-GFDL ! I hope I caught everything. Now I'll know better what to look for next time.

[MJHarrison-GFDL]

Thank you for making those changes Spencer. This PR looks good .

[marshallward]

Gaea regression: https://gitlab.gfdl.noaa.gov/ogrp/MOM6/-/jobs/106995 ✔️