Skip to content

[WIP]Fix PGI runtime issue with class(*)#346

Merged
marshallward merged 2 commits into
NOAA-GFDL:dev/gfdlfrom
nikizadehgfdl:fix_pgi_issue
Jun 12, 2023
Merged

[WIP]Fix PGI runtime issue with class(*)#346
marshallward merged 2 commits into
NOAA-GFDL:dev/gfdlfrom
nikizadehgfdl:fix_pgi_issue

Conversation

@nikizadehgfdl
Copy link
Copy Markdown

  • Some tests such as global_ALE_z crash under PGI (ncrc4.pgi20 or ncrc5.pgi227) with
    FATAL from PE 27: unsupported attribute type: get_variable_attribute_0d: file:INPUT/tideamp.nc- variable:GRID_X_T attribute: axis
  • PGI in general has issues with class(*) construct and in this case
    cannot recognize the axis argument to be a string.
  • This mod helps PGI recognize that the argument is a string.

- Some tests such as global_ALE_z crash under PGI (ncrc4.pgi20 or
ncrc5.pgi227) with
FATAL from PE    27: unsupported attribute type: get_variable_attribute_0d: file:INPUT/tideamp.nc- variable:GRID_X_T attribute: axis
- PGI in general has issues with class(*) construct and in this case
cannot recognize the axis argument to be a string.
- This mod helps PGI recognize that the argument is a string.
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 3, 2023

Codecov Report

Merging #346 (b4f1f0a) into dev/gfdl (b075794) will not change coverage.
The diff coverage is n/a.

❗ Current head b4f1f0a differs from pull request most recent head f8d215a. Consider uploading reports for the commit f8d215a to get more accurate results

@@            Coverage Diff            @@
##           dev/gfdl     #346   +/-   ##
=========================================
  Coverage     38.38%   38.38%           
=========================================
  Files           268      268           
  Lines         76010    76010           
  Branches      13987    13987           
=========================================
  Hits          29176    29176           
  Misses        41595    41595           
  Partials       5239     5239           

see 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@marshallward
Copy link
Copy Markdown
Member

Is this still happening in the current dev/gfdl? At least one instance of tideamp.nc was moved off of FMS and to the netCDF layer to avoid this issue.

@marshallward
Copy link
Copy Markdown
Member

@nikizadehgfdl Is there any update on this? Is this still a problem on the latest branch?

@marshallward
Copy link
Copy Markdown
Member

marshallward commented May 5, 2023

@nikizadehgfdl I tried the latest dev/gfdl with PGI and global_ALE/z appeared to run without any regressions, so I am tempted to close this issue.

Having said that, I did find a problem with data_override in PGI for several of the ice-ocean experiments. So I don't think we're at the end of this problem.

I'll let you decide how to proceed with this.

Copy link
Copy Markdown
Member

@marshallward marshallward left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suspect this is no longer necessary but I suppose there is no harm in it.

@marshallward
Copy link
Copy Markdown
Member

marshallward commented Jun 12, 2023

Gaea regression: https://gitlab.gfdl.noaa.gov/ogrp/MOM6/-/pipelines/19482 ✔️

@marshallward marshallward merged commit cb4574b into NOAA-GFDL:dev/gfdl Jun 12, 2023
marshallward pushed a commit that referenced this pull request Apr 15, 2025
Specify order of operations for accumulating runoff terms and SW_vis_tot. Do so by retaining the previous answers (hence some odd groupings of operations.)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants