Skip to content

Add better error handling to read_var_sizes #345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
marshallward merged 2 commits into from
Apr 21, 2023
Merged

Add better error handling to read_var_sizes #345

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d2e48c4
Add better error handling to read_var_sizes
Hallberg-NOAA Mar 30, 2023
9932a09
Merge branch 'dev/gfdl' into read_var_sizes_error_handling
marshallward Apr 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 10 additions & 4 deletions src/framework/MOM_io.F90
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -765,13 +765,13 @@ function num_timelevels(filename, varname, min_dims) result(n_time)

call get_var_sizes(filename, varname, ndims, sizes, match_case=.false., caller="num_timelevels")

n_time = sizes(ndims)
if (ndims > 0) n_time = sizes(ndims)

if (present(min_dims)) then
if (ndims < min_dims-1) then
write(msg, '(I3)') min_dims
call MOM_error(WARNING, "num_timelevels: variable "//trim(varname)//" in file "//&
trim(filename)//" has fewer than min_dims = "//trim(msg)//" dimensions.")
trim(filename)//" has fewer than min_dims = "//trim(msg)//" dimensions.")
n_time = -1
elseif (ndims == min_dims - 1) then
n_time = 0
Expand Down Expand Up @@ -861,12 +861,18 @@ subroutine read_var_sizes(filename, varname, ndims, sizes, match_case, caller, d
ncid = ncid_in
else
call open_file_to_read(filename, ncid, success=success)
if (.not.success) return
if (.not.success) then
call MOM_error(WARNING, "Unsuccessfully attempted to open file "//trim(filename))
return
endif
endif

! Get the dimension sizes of the variable varname.
call get_varid(varname, ncid, filename, varid, match_case=match_case, found=found)
if (.not.found) return
if (.not.found) then
call MOM_error(WARNING, "Could not find variable "//trim(varname)//" in file "//trim(filename))
return
endif

status = NF90_inquire_variable(ncid, varid, ndims=ndims)
if (status /= NF90_NOERR) then
Expand Down