Correct MLD_EN_VALS rescaling#342
Merged
marshallward merged 2 commits intoApr 20, 2023
Merged
Conversation
Correct inconsistent dimensional rescaling of the input values of MLD_EN_VALS, setting them all to [R Z3 T-2 ~> J m-2] to reflect that these are energies associated with vertical turbulent mixing. This fixes a rescaling bug when these energies are set to non-default values at runtime, but all answers and output are bitwise identical when no rescaling is used.
Codecov Report
@@ Coverage Diff @@
## dev/gfdl #342 +/- ##
=========================================
Coverage 37.07% 37.08%
=========================================
Files 264 264
Lines 74349 74349
Branches 13787 13787
=========================================
+ Hits 27568 27571 +3
+ Misses 41682 41681 -1
+ Partials 5099 5097 -2
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
breichl
approved these changes
Mar 29, 2023
breichl
left a comment
breichl
left a comment
There was a problem hiding this comment.
I agree with these changes, particularly because they make the energy scaling consistent with the approach in ePBL.
marshallward
approved these changes
Apr 20, 2023
Member
|
Gaea regression: https://gitlab.gfdl.noaa.gov/ogrp/MOM6/-/pipelines/18846 ✔️ |
pittwolfe
pushed a commit
to pittwolfe/MOM6
that referenced
this pull request
Apr 18, 2025
) When Auto Masking is enabled, the LAYOUT is unknown a priori, so it's not possible to predetermine a compatible IO_LAYOUT. This commit introduces an option to set a target number of IO PEs (TARGET_IO_PES), to be used as a reference for the auto masking routine to come up with an IO_LAYOUT compatible with LAYOUT on the fly. If original TARGET_IO_PES is not achievable without having to sacrifice too much land masking, IO PEs is decremented until a feasible combination of LAYOUT and IO_LAYOUT is found.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Correct inconsistent dimensional rescaling of the input values of MLD_EN_VALS, setting them all to [R Z3 T-2 ~> J m-2] to reflect that these are energies associated with vertical turbulent mixing. This fixes a rescaling bug when these energies are set to non-default values at runtime, but all answers and output are bitwise identical when no rescaling is used.