Reduced diagnostic memory footprint and MOM_sponge cleanup#34
Merged
marshallward merged 3 commits intoDec 14, 2021
Merged
Conversation
Eliminated 18 unnecessary 3-d allocatable arrays and 5 2-d allocatable arrays from the MOM_diagnostics control structure, replacing them with reused local stack arrays. Also collected the registration of time derivatives and the allocation of memory for intermediary diagnostics in set_dependent_diagnostics. All answers and output are bitwise identical.
Use the proper conversion factor for the w_sponge diagnostic, eliminated some unnecessary local copies of the domain sizes in the sponge control structure, and added more detailed descriptions of some of the variables in this module. All answers and output are bitwise identical.
Codecov Report
@@ Coverage Diff @@
## dev/gfdl #34 +/- ##
============================================
- Coverage 29.00% 28.96% -0.04%
============================================
Files 240 240
Lines 71237 71175 -62
============================================
- Hits 20665 20619 -46
+ Misses 50572 50556 -16
Continue to review full report at Codecov.
|
marshallward
approved these changes
Dec 14, 2021
Member
|
Gaea regression: https://gitlab.gfdl.noaa.gov/ogrp/MOM6/-/pipelines/14348 ✔️ |
This was referenced Jan 29, 2022
Hallberg-NOAA
added
the
refactor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR reduced the memory footprint with a rich set of diagnostics and cleans
up some aspects of the MOM_sponge code, including using a proper conversion
factor for one diagnostic. With this change, we may be able to run cases with
energy budget diagnostics in particular on fewer processors than before. All
answers and output are bitwise identical. The commits in this PR include: