Add KE_visc_gl90 diagnostic#305
Merged
Merged
Conversation
KE_visc_gl90 is an alternative to the diagnostic GLwork. Both diagnostics describe the energetics of the GL90 parameterization, as part of the kinetic energy budget. * KE_visc_gl90 is consistent with KE_visc, and the remaining KE diagnostics. In particular, it is true that KE_visc_gl90 is exactly contained in KE_visc, i.e., we have that KE_visc - KE_visc_gl90 represents exactly the energetics of all viscosity contributions except the GL90 viscosity. * GLwork is not directly compatible with KE_visc, but is guaranteed to be sign-definite if summed in the vertical.
Codecov Report
@@ Coverage Diff @@
## dev/gfdl #305 +/- ##
=========================================
Coverage 37.10% 37.11%
=========================================
Files 263 263
Lines 73799 73814 +15
Branches 13754 13757 +3
=========================================
+ Hits 27384 27396 +12
Misses 41354 41354
- Partials 5061 5064 +3
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
marshallward
approved these changes
Jan 19, 2023
marshallward
approved these changes
Jan 20, 2023
Member
marshallward
left a comment
marshallward
left a comment
There was a problem hiding this comment.
Thanks for making those changes. Since the dv_dt_visc_gl90 calculation was already reviewed, there should be no problem adding this and it looks ready to merge.
Member
|
Gaea regression: https://gitlab.gfdl.noaa.gov/ogrp/MOM6/-/pipelines/18033 ✔️ 🟡 |
This was referenced Apr 6, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up from PR #293.
KE_visc_gl90is an alternative to the diagnosticGLwork. Both diagnostics describe the energetics of the GL90 parameterization, as part of the kinetic energy budget.KE_visc_gl90is consistent withKE_visc, and the remaining KE diagnostics. In particular, it is true thatKE_visc_gl90is exactly contained inKE_visc, i.e., we have thatKE_visc-KE_visc_gl90represents exactly the energetics of all viscosity contributions except the GL90 viscosity.GLwork is not directly compatible with
KE_visc, but is guaranteed to be sign-definite if summed in the vertical.The figures below show snapshots of the vertically summed diagnostics
KE_visc_gl90andGLwork.