Update indexing of array passed to data_override.#30
Merged
marshallward merged 2 commits intoDec 10, 2021
Merged
Conversation
The arrays passed to data_overrride need to be sized as the compute domain. Added indices to pass to data_override.
Codecov Report
@@ Coverage Diff @@
## dev/gfdl #30 +/- ##
=========================================
Coverage 29.05% 29.05%
=========================================
Files 240 240
Lines 71293 71293
=========================================
Hits 20712 20712
Misses 50581 50581 Continue to review full report at Codecov.
|
marshallward
approved these changes
Dec 10, 2021
Member
marshallward
left a comment
marshallward
left a comment
There was a problem hiding this comment.
This looks correct and is consistent with the other drivers.
Member
|
Gaea regression: https://gitlab.gfdl.noaa.gov/ogrp/MOM6/-/pipelines/14313 ✔️ |
This was referenced Jan 29, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The arrays passed to data_overrride need to be sized as the compute
domain. Added indices to pass to data_override.