+Add runtime params KV_RESTRAT & RESTRAT_USTAR_MIN#266
Merged
Conversation
Hallberg-NOAA
force-pushed
the
Add_Kv_restrat
branch
from
f35fcbf to
db1c1f8
Compare
Codecov Report
@@ Coverage Diff @@
## dev/gfdl #266 +/- ##
============================================
- Coverage 37.12% 37.08% -0.05%
============================================
Files 263 263
Lines 73444 73392 -52
Branches 13674 13677 +3
============================================
- Hits 27268 27217 -51
+ Misses 41151 41141 -10
- Partials 5025 5034 +9
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Hallberg-NOAA
added
enhancement
Hallberg-NOAA
force-pushed
the
Add_Kv_restrat
branch
2 times, most recently
from
1c04ddc to
bc0e923
Compare
Added the runtime parameters KV_RESTRAT and RESTRAT_USTAR_MIN, to build on the improvements in github.com/NOAA-GFDL/pull/251, and to provide run-time physical parameters to avoid the potential division by zero in the mixed_layer_restrat code noted at github.com/mom-ocean/issues/1168. Once this PR is merged onto the main branch of MOM6, that issue can be closed. By default, these do not change answers in the MOM6-examples test suite, but the default value for RESTRAT_USTAR_MIN was taken from the hard-coded value in PR that PR. The six copies of the eddy growth rate timescale calculations were consolidated into a new internal function, growth_time, with some other related minor refactoring of the code. Also, mixedlayer_restrat_register_restarts now takes a unit_scale_type arguments like many other analogous routines. All answers are bitwise identical, but there are new runtime parameters or comments that lead to changes in the MOM_parameter_doc files. Also clarified in the comments sent to the MOM_parameter_doc files how VISBECK_L_SCALE works as a dimensional scaling factor when it is given a negative value, and rescaled its units when read as though it were always in m.
Hallberg-NOAA
force-pushed
the
Add_Kv_restrat
branch
from
bc0e923 to
cacfd8c
Compare
Member
|
Gaea regression: https://gitlab.gfdl.noaa.gov/ogrp/MOM6/-/pipelines/17727 ✔️ 🟡 |
marshallward
approved these changes
Dec 19, 2022
This was referenced Apr 6, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added the runtime parameters KV_RESTRAT and RESTRAT_USTAR_MIN, to build on the improvements in github.com//pull/251, and to provide run-time physical parameters to avoid the potential division by zero in the mixed_layer_restrat code noted at github.com/mom-ocean/issues/1168. Once this PR is merged onto the main branch of MOM6, that issue can be closed. By default, these do not change answers in the MOM6-examples test suite, but the default value for RESTRAT_USTAR_MIN was taken from the hard-coded value in PR that PR. The six copies of the eddy growth rate timescale calculations were consolidated into a new internal function, growth_time, with some other related minor refactoring of the code. Also, mixedlayer_restrat_register_restarts now takes a unit_scale_type arguments like many other analogous routines. All answers are bitwise identical, but there are new runtime parameters or comments that lead to changes in the MOM_parameter_doc files.
Also clarified in the comments sent to the MOM_parameter_doc files how VISBECK_L_SCALE works as a scaling factor when it is given a negative value, but rescaled its units when read as though it were always in m.