+Rescale forcing arguments and revise ctrl_forcing#25
Merged
marshallward merged 3 commits intoDec 8, 2021
Conversation
This commit revisits the units of the input arguments to the various ocean- only surfaces forcing routines, including: - Rescaled the units of the time intervals passed to the various forcing routines to [T ~> s] - Applied dimensional scaling to MOM_controlled_forcing.F90. This code is not yet in active use, so these changes can not change answers, but it is now much closer to compliance with modern MOM6 standards, including improved documentation, and could be ready to try without too much more effort. - Documented the remaining real variables in benchmark_initialization.F90, along with their units. All answers are bitwise identical, but there are changes to the units of some arguments in public interfaces.
Codecov Report
@@ Coverage Diff @@
## dev/gfdl #25 +/- ##
============================================
- Coverage 29.07% 29.06% -0.01%
============================================
Files 240 240
Lines 71289 71319 +30
============================================
+ Hits 20728 20731 +3
- Misses 50561 50588 +27
Continue to review full report at Codecov.
|
marshallward
approved these changes
Dec 8, 2021
This was referenced Jan 29, 2022
Hallberg-NOAA
added
documentation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit revisits the units of the input arguments to the various ocean-
only surfaces forcing routines, including:
routines to [T ~> s]
not yet in active use, so these changes can not change answers, but it is
now much closer to compliance with modern MOM6 standards, including improved
documentation, and could be ready to try without too much more effort.
along with their units.
All answers are bitwise identical, but there are changes to the units of some
arguments in public interfaces.