+Add remapping of auxiliary variables in restarts#233
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## dev/gfdl #233 +/- ##
============================================
- Coverage 37.17% 37.09% -0.08%
============================================
Files 263 263
Lines 73221 73368 +147
Branches 13638 13672 +34
============================================
+ Hits 27218 27219 +1
- Misses 40978 41121 +143
- Partials 5025 5028 +3
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Hallberg-NOAA
force-pushed
the
remap_aux_vars
branch
from
1a24dae to
47557b2
Compare
Hallberg-NOAA
force-pushed
the
remap_aux_vars
branch
from
47557b2 to
b108529
Compare
Member
|
There's a conflict here, do you want to resolve it? I can do it, but it will create a new commit. |
Hallberg-NOAA
force-pushed
the
remap_aux_vars
branch
from
b108529 to
71ab090
Compare
Hallberg-NOAA
force-pushed
the
remap_aux_vars
branch
from
71ab090 to
987a0ef
Compare
Added a new logical argument to interpolate_column to specify whether the interpolated interface values outside of massless layers should be masked to zero. Also refactored the code in interpolate_column to separate out the determination of the interface position from the interpolation and the masking to facilitate the extension of this code to use higher order interpolation in planned subsequent changes. All answers are bitwise identical, although there is a new mandatory argument for a public interface.
Added ALE_remap_interface_vals and ALE_remap_vertex_vals to handle the interpolation of variables that are at the interfaces atop tracer cells or above the corners of the tracers cells from one grid to another. Because these are not yet used (but have been tested in calls that will be added with the next commit) all answers are bitwise identical, but there are two new publicly visible routines.
Added REMAP_AUXILIARY_VARS to control whether to remap the accelerations that are used in the predictor step of the split RK2 time stepping scheme. Also added the new routines remap_dyn_split_rk2_aux_vars, remap_OBC_fields and remap_vertvisc_aux_vars to do the remapping, and code to call these routines when REMAP_AUXILIARY_VARS is true. By default, REMAP_AUXILIARY_VARS is false, and all answers are bitwise identical, but the entire MOM6-examples regression suite has been run with this set to true, and they do appear to give physically plausible answers in all cases, partially addressing the issue noted at github.com/NOAA-GFDL/issues/203. New entries are added to the MOM_parameter_doc files, and there are three new publicly visible routines, but by default answers do not change.
Hallberg-NOAA
force-pushed
the
remap_aux_vars
branch
from
31bc607 to
ba389e0
Compare
Member
|
Gaea regression: https://gitlab.gfdl.noaa.gov/ogrp/MOM6/-/pipelines/17502 ✔️ 🟡 New parameter:
|
marshallward
approved these changes
Nov 22, 2022
marshallward
pushed a commit
that referenced
this pull request
Apr 4, 2023
POSIX: siglongjmp and sigsetjmp_missing fixes
This was referenced Apr 6, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR consists of a series of commits that add the capability, selected at
runtime via the new parameter REMAP_AUXILIARY_VARS, to remap all of the 3-d
variables that are registered for restarts but were not previously remapped.
This PR addresses the issue at github.com//issues/203 in cases
using ALE remapping, but it may also be worthwhile to examine this issue in
non-ALE cases as well. There are several new interfaces and a new runtime
parameter, so the contents of the MOM_parameter_doc files change, but by
default all answers are bitwise identical.
The commits in this PR include:
(This PR was updated via a force-push at 6 AM on 11/18/2022 to correct bugs found during its review.)