Document variable units in core modules#214
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## dev/gfdl #214 +/- ##
============================================
+ Coverage 37.14% 37.20% +0.05%
============================================
Files 263 262 -1
Lines 73048 72867 -181
Branches 13624 13619 -5
============================================
- Hits 27136 27110 -26
+ Misses 40894 40741 -153
+ Partials 5018 5016 -2
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Hallberg-NOAA
force-pushed
the
core_var_units
branch
from
e55e981 to
09374f5
Compare
marshallward
approved these changes
Oct 19, 2022
Member
marshallward
left a comment
marshallward
left a comment
There was a problem hiding this comment.
Thanks very much for dedicating a separate PR for these changes.
Revised or extended comments to correct or more clearly document the units of 49 internal variables in modules in the core directory. All answers are bitwise identical.
Hallberg-NOAA
force-pushed
the
core_var_units
branch
from
09374f5 to
096c35a
Compare
Member
|
Gaea regression: https://gitlab.gfdl.noaa.gov/ogrp/MOM6/-/pipelines/17156 ✔️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Revised or extended comments to correct or more clearly document the units of
49 internal variables in modules in the core directory. All answers are bitwise identical.