Testing: Codecov uploader update#21
Merged
Hallberg-NOAA merged 2 commits intoDec 6, 2021
Merged
Conversation
This patches updates the codecov uploader to the new version, replacing the bash uploader to be phased out in 2022. The uploader URL is now a configuable variable, and the coverage scripts have been modified to accommodate changes in the uploader. Under this new uploader, the coverage reports must be generated locally, rather than relying on the bash script to call gcov. So we now generate these scripts based on the *.gcda output.
Codecov Report
@@ Coverage Diff @@
## dev/gfdl #21 +/- ##
=========================================
Coverage 29.17% 29.17%
=========================================
Files 240 240
Lines 71493 71491 -2
=========================================
Hits 20856 20856
+ Misses 50637 50635 -2
Continue to review full report at Codecov.
|
Hallberg-NOAA
approved these changes
Dec 6, 2021
Member
Hallberg-NOAA
left a comment
Hallberg-NOAA
left a comment
There was a problem hiding this comment.
These changes look sensible to me, and this has passed the TC testing. In this particular case there is no point in running the pipeline tests on these changes, so the TC testing alone will suffice.
This was referenced Jan 29, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patches updates the codecov uploader to the new version, replacing
the bash uploader to be phased out in 2022.
The uploader URL is now a configuable variable, and the coverage scripts
have been modified to accommodate changes in the uploader.
Under this new uploader, the coverage reports must be generated locally,
rather than relying on the bash script to call gcov. So we now generate
these scripts based on the *.gcda output.