FMS2: open_ASCII_file and open_namelist_file#206
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## dev/gfdl #206 +/- ##
============================================
- Coverage 37.17% 37.15% -0.02%
============================================
Files 261 262 +1
Lines 72357 72745 +388
Branches 13513 13597 +84
============================================
+ Hits 26899 27032 +133
- Misses 40477 40699 +222
- Partials 4981 5014 +33
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
This patch re-implements the FMS2 implementations of `open_ASCII_file`
and `open_namelist_file` to remove their dependency on FMS1 functions
which have been staged for deletion.
Note that if a file is opened with `mpp_open` but closed with
`close_file_unit`, then it will raise an error in `fms_io_exit`.
This will no longer be an issue after all references to `mpp_open` have
been removed. But in the meantime, we will need to ensure that all
unit-based `close_file` calls were not opened with `mpp_open`.
There is also a minor patch to `.testing/Makefile` which selects the
framework ("infra") source dependency, rather than hard-set to FMS1.
Hallberg-NOAA
force-pushed
the
read_ascii
branch
from
cf5ea96 to
e8ec939
Compare
Hallberg-NOAA
approved these changes
Sep 21, 2022
Member
Hallberg-NOAA
left a comment
Hallberg-NOAA
left a comment
There was a problem hiding this comment.
These changes seem like a sensible and useful step toward separating our FMS2 infrastructure code from any dependencies on the older FMS1 routines.
Member
|
This PR has passed pipeline testing at https://gitlab.gfdl.noaa.gov/ogrp/MOM6/-/pipelines/16838. |
chzhangudel
pushed a commit
to chzhangudel/MOM6
that referenced
this pull request
Sep 29, 2022
Merging main candidate from Dec 20, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch re-implements the FMS2 implementations of
open_ASCII_fileandopen_namelist_fileto remove their dependency on FMS1 functions which have been staged for deletion.Note that if a file is opened with
mpp_openbut closed withclose_file_unit, then it will raise an error infms_io_exit. This will no longer be an issue after all references tompp_openhave been removed. But in the meantime, we will need to ensure that all unit-basedclose_filecalls were not opened withmpp_open.There is also a minor patch to
.testing/Makefilewhich selects the framework ("infra") source dependency, rather than hard-set to FMS1.