Avoid extra post_data calls from vertvisc#204
Merged
marshallward merged 1 commit intoSep 16, 2022
Conversation
Codecov Report
@@ Coverage Diff @@
## dev/gfdl #204 +/- ##
============================================
+ Coverage 37.14% 37.15% +0.01%
============================================
Files 262 262
Lines 72744 72723 -21
Branches 13596 13596
============================================
Hits 27023 27023
+ Misses 40707 40684 -23
- Partials 5014 5016 +2
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Add calls to query_averaging_enabled to avoid unnecessary extra calls to post_data for diagnostics that will never be used in vertvisc and vertvisc_coef. All answers are bitwise identical, but the C.I. testing appears to fail because there are fewer calls to post_data.
Hallberg-NOAA
force-pushed
the
vertvisc_less_diags
branch
from
702d183 to
ec4a45e
Compare
Member
marshallward
approved these changes
Sep 16, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add calls to query_averaging_enabled to avoid unnecessary extra calls to post_data for diagnostics that will never be used in vertvisc and vertvisc_coef. All answers are bitwise identical, but the C.I. testing appears to fail because there are fewer calls to post_data.