MacOS CI fix + verbose builds on error#185
Merged
Merged
Conversation
This patch adds the `REPORT_ERROR_LOGS` variable to the .testing and ac/deps makefiles. When set to true, a failed FMS build will also echo the contents of `config.log`, in order to diagnose remote CI builds. The variable is disabled on default, to reduce the amount of output at command line. It has been added to the GitHub Actions CI, and is propagated through `.testing/Makefile`. Although not used in the MOM6 builds, it could be extended to them if it proves useful. Currently, these Makefiles always echo `config.log` after a failed build.
This patch fixes the gcc compiler environment variables on their MacOS systems. GitHub recently made some GCC compiler changes on their MacOS machines; specifically, `gcc-11` and `gfortran-11` appear to no longer be available. Previously, we were unable to use the default gcc and had to use these executables. On this newer version, we can use the default system gcc, and the `CC` environment variable can be left unset. We still need `FC` to point to `gfortran`, since it otherwise tries to build with `f77`, which does not exist.
Codecov Report
@@ Coverage Diff @@
## dev/gfdl #185 +/- ##
=========================================
Coverage 37.38% 37.38%
=========================================
Files 259 259
Lines 71997 71997
Branches 13515 13515
=========================================
Hits 26916 26916
Misses 40094 40094
Partials 4987 4987 📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
Hallberg-NOAA
approved these changes
Aug 8, 2022
Member
Hallberg-NOAA
left a comment
Hallberg-NOAA
left a comment
There was a problem hiding this comment.
This PR corrects problems that have recently arisen with the MacOS CI testing, and adds more verbosity when the CI testing encounters errors. This seems to me like a necessary change, preempting other PRs that have been awaiting action longer.
This PR has passed pipeline testing at https://gitlab.gfdl.noaa.gov/ogrp/MOM6/-/pipelines/16312 without any changes to answers or output.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two changes in this PR:
Resolves the MacOS build issues by removing the environment variables pointing to gcc-11 and gfortran-11 compiler (which seem to no longer be supported). The CC is removed and FC now just points to gfortran.
If the dependency ./configure fails for any reason, the config.log output is now streamed to the CI log, which should make future debugging easier.