+Remove inappropriate stochastics output#183
Merged
marshallward merged 3 commits intoAug 8, 2022
Merged
Conversation
Modified output from MOM_stochastics to stdout to only occur if the stochastics code is actively being used, and to only register stochastics related diagnostics if they are actually available. Also, initialized some stochastics arrays to 0 when they are allocated. Some indenting and white space were also changed to bring the MOM_stochastics code into closer compliance with MOM6 code standards. All answers are bitwise identical, but there will be fewer inappropriate entries in the available_diags files, and some output to stdout will only occur when appropriate and be subject to verbosity control.
Codecov Report
@@ Coverage Diff @@
## dev/gfdl #183 +/- ##
============================================
+ Coverage 37.10% 37.38% +0.28%
============================================
Files 259 259
Lines 71568 71981 +413
Branches 13445 13517 +72
============================================
+ Hits 26553 26911 +358
- Misses 40052 40081 +29
- Partials 4963 4989 +26
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
Member
|
Gaea regression: https://gitlab.gfdl.noaa.gov/ogrp/MOM6/-/pipelines/16340 ✔️ |
marshallward
approved these changes
Aug 8, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Modified output from MOM_stochastics to stdout to only occur if the
stochastics code is actively being used, and to only register stochastics
related diagnostics if they are actually available. Also, initialized some
stochastics arrays to 0 when they are allocated. Some indenting and white space
were also changed to bring the MOM_stochastics code into closer compliance with
MOM6 code standards. All answers are bitwise identical, but there will be fewer
inappropriate entries in the available_diags files, and some output to stdout
will only occur when appropriate and be subject to verbosity control.