Fatal error if a tracer package is registered twice#182
Merged
marshallward merged 3 commits intoAug 8, 2022
Merged
Conversation
Made the WARNING error messages that were issued if a tracer package registration routine is called with an associated control structure into FATAL errors, as suggested by github.com/mom-ocean/issues/1444. A tracer package could be used twice, but it would require the use of separate control structures for each instance. This change will bring down the model in a case that probably should not be running. All solutions are bitwise identical in any cases that run, and all MOM6-examples test cases work exactly as before.
Codecov Report
@@ Coverage Diff @@
## dev/gfdl #182 +/- ##
=========================================
Coverage 37.38% 37.39%
=========================================
Files 259 259
Lines 71997 71981 -16
Branches 13515 13515
=========================================
Hits 26916 26916
+ Misses 40094 40078 -16
Partials 4987 4987
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
marshallward
approved these changes
Aug 8, 2022
Member
|
Gaea regression: https://gitlab.gfdl.noaa.gov/ogrp/MOM6/-/pipelines/16331 ✔️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Made the WARNING error messages that were issued if a tracer package
registration routine is called with an associated control structure into FATAL
errors, as suggested by github.com/mom-ocean/issues/1444. A tracer package
could be used twice, but it would require the use of separate control structures
for each instance. This change will bring down the model in a case that
probably should not be running. All solutions are bitwise identical in any
cases that run, and all MOM6-examples test cases work exactly as before.