+Non-Boussinesq thickness diagnostics in kg m-2#181
Merged
Conversation
Modified the units for 10 thickness or thickness tendency diagnostics to write them in their native units (e.g., kg m-2) when run in non-Boussinesq mode. These changes were proposed in mom-ocean#1565 and discussed and agreed to at the MOM6 dev call on 4/25/22. Previously these diagnostics had been converted to approximate thicknesses in m using a constant reference density, but this was only accurate to about 0.1% and could be misinterpreted. A number of other (more commonly used) thickness-related variables were already being written in their native units, and this makes the model's output more self consistent. All solutions are bitwise identical, but some diagnostics will change when run in non-Boussinesq mode.
Codecov Report
@@ Coverage Diff @@
## dev/gfdl #181 +/- ##
============================================
- Coverage 37.40% 37.39% -0.01%
============================================
Files 259 259
Lines 71848 71698 -150
Branches 13443 13408 -35
============================================
- Hits 26873 26812 -61
+ Misses 40031 39962 -69
+ Partials 4944 4924 -20
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
marshallward
approved these changes
Aug 3, 2022
Member
|
Gaea regression: https://gitlab.gfdl.noaa.gov/ogrp/MOM6/-/pipelines/16292 ✔️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Modified the units for 10 thickness or thickness tendency diagnostics to write
them in their native units (e.g., kg m-2) when run in non-Boussinesq mode. These
changes were proposed in mom-ocean#1565 and
discussed and agreed to at the MOM6 dev call on 4/25/22. Previously these
diagnostics had been converted to approximate thicknesses in m using a constant
reference density, but this was only accurate to about 0.1% and could be
misinterpreted. A number of other (more commonly used) thickness-related
variables were already being written in their native units, and this makes the
model's output more self consistent. All solutions are bitwise identical, but
some diagnostics will change when run in non-Boussinesq mode.