Fix to bottom drag as a body force#176
Conversation
DRAG_AS_BODY_FORCE was using two inconsistent values for the bottom boundary layer. It now always uses HBBL, or the total water depth if that is less than HBBL. Results with DRAG_AS_BODY_FORCE=False are unchanged.
Codecov Report
@@ Coverage Diff @@
## dev/gfdl #176 +/- ##
============================================
+ Coverage 37.20% 37.40% +0.20%
============================================
Files 258 259 +1
Lines 70733 71840 +1107
Branches 13158 13442 +284
============================================
+ Hits 26314 26871 +557
- Misses 39653 40025 +372
- Partials 4766 4944 +178
Help us with your feedback. Take ten seconds to tell us how you rate us. |
Hallberg-NOAA
left a comment
Hallberg-NOAA
left a comment
There was a problem hiding this comment.
I agree that these changes correct a bug with the new body_force_drag option, which will now work as intended.
There is an interaction between this code change and the bottom boundary layer thickness used in the channel_drag code block, analogously to what had previously been done when Richardson number driven mixing is enabled. Although this seems sensible enough, it should perhaps be reconsidered, for both the new option and when the Richardson number mixing is enabled.
|
Gaea regression: https://gitlab.gfdl.noaa.gov/ogrp/MOM6/-/pipelines/16260 ✔️ 🟡 As expected, there is a parameter change due to the updated docstring. |
3 participants
DRAG_AS_BODY_FORCE was using two inconsistent values for the bottom boundary layer.
It now always uses HBBL, or the total water depth if that is less than HBBL.
Results with the default DRAG_AS_BODY_FORCE=False are unchanged.