Fixes minor issues with ac/make process#174
Merged
Merged
Conversation
Where we had placed the dependency discovery (makedep) was leading to some small annoyances: - The dependency generation was being invoked twice - The dependency generation was not invoked when source code was changed. Now: - `./configure` creates config.status Makefile and Makefile.dep - `./config.status` recreates Makefile and Makefile.dep - `make depend` recreates Makefile.dep - `make` will conditionally recreate Makefile.dep Changes: - Add dependency of Makefile.dep on source code in Makefile.in. This allows `make` to know when to run `makedep`. - Fix syntax issue for AC_CONFIG_COMMANDS which caused errors to be issued without stopping. Side note: the system works perfectly well if we comment out the "AC_CONFIG_COMMANDS" line in configure.ac to invoke makedep. This is because `make` now knows how
Codecov Report
@@ Coverage Diff @@
## dev/gfdl #174 +/- ##
=========================================
Coverage 34.01% 34.01%
=========================================
Files 259 259
Lines 70289 70289
Branches 13021 13021
=========================================
Hits 23906 23906
Misses 41879 41879
Partials 4504 4504 Help us with your feedback. Take ten seconds to tell us how you rate us. |
marshallward
approved these changes
Jul 27, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Where we had placed the dependency discovery (makedep) was leading to some small annoyances:
Now:
./configurecreates config.status Makefile and Makefile.dep./config.statusrecreates Makefile and Makefile.depmake dependrecreates Makefile.depmakewill conditionally recreate Makefile.depChanges:
maketo know when to runmakedep.Side note: the system works perfectly well if we comment out the "AC_CONFIG_COMMANDS" line in configure.ac to invoke makedep. This is because
makenow knows how