(*)Fix set_up_ALE_sponge_field call T & S scaling#173
Merged
marshallward merged 1 commit intoJul 22, 2022
Merged
Conversation
Corrected the dimensional rescaling factors in two calls to set_up_ALE_sponge_field for temperature and salinity for time-varying fields being read in from an input file. These had been given the inverse of the correct values. An optional scale argument was also added (with its default value) in the call to set up ALE sponge velocities, for greater clarity of what this call is doing. This commit should address an issue noted by Kate Hedstrom when evaluating the first draft of PR mom-ocean#1577 from dev/gfdl to main. All answers are bitwise identical in cases where dimensional rescaling of temperature and salinity are not being applied, and answers with the rescaling of temperature and salinity should now reproduce those without the rescaling.
Hallberg-NOAA
changed the base branch from
dev/gfdl
to
dev-candidate-main-2022-07-21
Codecov Report
@@ Coverage Diff @@
## dev-candidate-main-2022-07-21 #173 +/- ##
==============================================================
Coverage 33.99% 33.99%
==============================================================
Files 259 259
Lines 70267 70267
Branches 13023 13023
==============================================================
Hits 23885 23885
Misses 41880 41880
Partials 4502 4502
Help us with your feedback. Take ten seconds to tell us how you rate us. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Corrected the dimensional rescaling factors in two calls to
set_up_ALE_sponge_field for temperature and salinity for time-varying fields
being read in from an input file. These had been given the inverse of the
correct values. An optional scale argument was also added (with its default
value) in the call to set up ALE sponge velocities, for greater clarity of what
this call is doing. This commit should address an issue noted by Kate Hedstrom
when evaluating the first draft of PR mom-ocean#1577 from dev/gfdl to main. All answers
are bitwise identical in cases where dimensional rescaling of temperature and
salinity are not being applied, and answers with the rescaling of temperature
and salinity should now reproduce those without the rescaling.