+Rescaled flux arguments to tracer_vertdiff()#17
Merged
marshallward merged 2 commits intoDec 5, 2021
Conversation
Changed the units of the optional surface and bottom tracer fluxes, sink rate, and bottom tracer reservoir arguments to tracer_vertdiff() and tracer_vertdiff_Eulerian() to fully rescaled units (like [Conc R Z T-1] and [Z T-1]) for greater dimensional consistency testing. Only the two CFC packages are using the flux arguments, so they were rescaled in those modules as well. Several unused variables or unnecessary pointers were removed from the CFC tracer modules, and some comments were revised or added to indicate the dimensions of a number of internal variables in these same modules. All answers are bitwise identical in the MOM6-examples regression suite, and only dimensional rescaling factors are changed (so nothing will have changed without any rescaling), but it should be noted that testing of the CFC tracer packages is less comprehensive than would be ideal.
Codecov Report
@@ Coverage Diff @@
## dev/gfdl #17 +/- ##
=========================================
Coverage 29.16% 29.17%
=========================================
Files 240 240
Lines 71496 71488 -8
=========================================
Hits 20854 20854
+ Misses 50642 50634 -8
Continue to review full report at Codecov.
|
marshallward
approved these changes
Dec 5, 2021
Member
|
Gaea regression: https://gitlab.gfdl.noaa.gov/ogrp/MOM6/-/pipelines/14260 ✔️ |
This was referenced Jan 29, 2022
Hallberg-NOAA
added
the
refactor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changed the units of the optional surface and bottom tracer fluxes, sink rate, and
bottom tracer reservoir arguments to tracer_vertdiff() and tracer_vertdiff_Eulerian()
to fully rescaled units (like [Conc R Z T-1 ~> mol m-2 s-1] and [Z T-1 ~> m s-1]) for
greater dimensional consistency testing.
Only the two CFC packages are using the flux arguments, so these fluxes were rescaled
in those modules as well. Several unused variables or unnecessary pointers were removed
from the CFC tracer modules, and some comments were revised or added to indicate the
dimensions of a number of internal variables in these same modules.
All answers are bitwise identical in the MOM6-examples regression suite, and only
dimensional rescaling factors are changed (so nothing will have changed without
any rescaling), but it should be noted that testing of the CFC tracer packages
is less comprehensive than would be ideal.