+Restored public interface to post_data_1d_k#169
Merged
marshallward merged 1 commit intoJul 18, 2022
Conversation
Made post_data_1d_k publicly visible once again, rather than requiring calls to use post_data, to support backward compatibility with older versions of the ocean_BGC code. This interface was removed from public visibility as a part of github.com/NOAA-GFDL/pull/107, but it caused problems with some of GFDL's Earth System Models, as noted in NOAA-GFDL#168. All answers are bitwise identical for any cases that compiled before.
Codecov Report
@@ Coverage Diff @@
## dev/gfdl #169 +/- ##
=========================================
Coverage 33.99% 33.99%
=========================================
Files 259 259
Lines 70248 70248
Branches 13016 13016
=========================================
Hits 23884 23884
Misses 41865 41865
Partials 4499 4499
Continue to review full report at Codecov.
|
Member
|
Gaea regression: https://gitlab.gfdl.noaa.gov/ogrp/MOM6/-/pipelines/16148 ✔️ |
marshallward
approved these changes
Jul 18, 2022
marshallward
pushed a commit
that referenced
this pull request
Mar 12, 2026
update MOM6 to its main repo. 20260112 updating
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Made post_data_1d_k publicly visible once again, rather than requiring calls
to use post_data, to support backward compatibility with older versions of the
ocean_BGC code. This interface was removed from public visibility as a part of
github.com//pull/107, but it caused problems with some of GFDL's
Earth System Models, as noted in #168.
All answers are bitwise identical for any cases that compiled before.