*+DOME initialization cleanup and bug fix#165
Merged
marshallward merged 3 commits intoJul 17, 2022
Conversation
Removed a line resetting temperatures to 0 for the ZSTAR and SIGMA vertical coordinates in DOME2d_initialize_temperature_salinity, after they had been set to the intended values. github.com/mom-ocean/issues/1560 highlights this bug and can be closed after this commit is merged into the main branch of MOM6. This changes the temperature fields (and ocean.stats files) for the flow_downslopes/z and flow_downslopes/sigma test cases, but because temperature does not influence density in these cases, the flows and salinities are unchanged.
Modified the DOME initialization to simplify some expressions and to use run-time parameters, rather than hard-coded values, when initializing the DOME test case. By default, all expressions are mathematically equivalent, but there are roundoff level changes in the topography and sponges due to the use of more generally valid expressions with runtime parameters and the replacement of some divisions for unit conversions by multiplication by a reciprocal. Because the DOME test cases are strongly nonlinear, these small changes cascade up to macroscopic differences, but these are of comparable magnitude to the differences between compilers. There are 10 new runtime parameters that appear in the MOM_parameter_doc.all files for the DOME test cases.
Codecov Report
@@ Coverage Diff @@
## dev/gfdl #165 +/- ##
============================================
- Coverage 34.01% 34.01% -0.01%
============================================
Files 259 259
Lines 70209 70218 +9
Branches 13012 13011 -1
============================================
Hits 23884 23884
- Misses 41826 41835 +9
Partials 4499 4499
Continue to review full report at Codecov.
|
Hallberg-NOAA
added
bug
Member
|
Gaea regression: https://gitlab.gfdl.noaa.gov/ogrp/MOM6/-/pipelines/16123 ❌ Failed as expected: Failed runs
Failed parameters:
|
Member
Author
|
These are the 3 cases where the answers are expected to change. |
marshallward
approved these changes
Jul 17, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR includes two sets of changes that change answers in the DOME and
flow_downslopes test cases. One change corrects an obvious bug in
DOME2d_initialize_temperature_salinity that reset the temperatures to 0 with the
ZSTAR and SIGMA vertical coordinates. The other set of changes to the DOME
initialization is mathematically equivalent to what was there before, but
revises the expressions setting up the DOME test case to use runtime parameters,
more gracefully accomodates changes to those parameters, and replaces some
divisions with multiplication by a reciprocal. There are changes to the DOME
MOM_parameter_doc.all file, and answer changes in the DOME and two variants of
the flow_downslope test cases. This commits in this PR include: