Fix to reading of partial OBCs from file.#164
Conversation
Codecov Report
@@ Coverage Diff @@
## dev/gfdl #164 +/- ##
=========================================
Coverage 34.01% 34.01%
=========================================
Files 259 259
Lines 70209 70209
Branches 13012 13012
=========================================
Hits 23884 23884
Misses 41826 41826
Partials 4499 4499
Continue to review full report at Codecov.
|
Hallberg-NOAA
left a comment
Hallberg-NOAA
left a comment
There was a problem hiding this comment.
I have examined these changes, and I think that I understand what they are doing.
These expressions now have become very long, and could be simplified and made easier to understand and perhaps facilitate future modifications by defining new variables, like j_file_off = G%jdg_offset - segment%HI%Jsgb (and similarly for i_file_off) or else to define variables like js_obc_file = js_obc + G%jdg_offset - segment%HI%Jsgb (and similarly for je_obc_file, is_obc_file and ie_obc_file) at about line 3740 of this file. However, these simplifications could be made in a future change, after this PR has been merged into the code.
|
This is from dev/esmg, so this commit needs to be merge-commited. |
|
Gaea regression: https://gitlab.gfdl.noaa.gov/ogrp/MOM6/-/pipelines/16121 ✔️ |
* Add a variable to shorten some statements - suggested by @Hallberg-NOAA in the discussion for #164 * Fix to small i/j error
Move computation of tmp_h inside the if G%mask2dT test to avoid divide by zero error
3 participants
Fix to issue #163