+Eliminated 3 unused elements of the surface type#145
Merged
marshallward merged 2 commits intoJun 20, 2022
Conversation
Eliminated the salt_deficit, TempxPmE and internal heat elements of the surface type. None of these particular elements are used outside of MOM6, and they are not used again after they are set, and appear not to have been used in many years. All answers are bitwise identical.
Codecov Report
@@ Coverage Diff @@
## dev/gfdl #145 +/- ##
============================================
- Coverage 34.26% 34.25% -0.01%
============================================
Files 257 257
Lines 69744 69721 -23
Branches 12913 12909 -4
============================================
- Hits 23897 23885 -12
+ Misses 41373 41365 -8
+ Partials 4474 4471 -3
Continue to review full report at Codecov.
|
Member
|
Gaea regression: https://gitlab.gfdl.noaa.gov/ogrp/MOM6/-/pipelines/15939 ✔️ |
marshallward
approved these changes
Jun 20, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Eliminated the salt_deficit, TempxPmE and internal heat elements of the
surface type. None of these particular elements are used outside of MOM6, and
they are not used again after they are set, and appear not to have been used in
many years. All answers are bitwise identical.