Skip to content

Minor code cleanup in drivers/FMS_cap#14

Merged
marshallward merged 2 commits into
NOAA-GFDL:dev/gfdlfrom
Hallberg-NOAA:FMS_cap_rescaling
Nov 30, 2021
Merged

Minor code cleanup in drivers/FMS_cap#14
marshallward merged 2 commits into
NOAA-GFDL:dev/gfdlfrom
Hallberg-NOAA:FMS_cap_rescaling

Conversation

@Hallberg-NOAA
Copy link
Copy Markdown
Member

@Hallberg-NOAA Hallberg-NOAA commented Nov 28, 2021

Various minor code cleanup in the drivers/FMS_cap directory, including:

  • Rescaled the internal latent_heat variables in the control structure for MOM_surface_forcing_gfdl for improved dimensional consistency testing.
  • Removed the unused local variable PmE_adj in convert_IOB_to_fluxes().
  • Corrected the documented units or fixed spelling errors in several comments.

All answers and output are bitwise identical.

Various minor code cleanup in the drivers/FMS_cap directory, including:
  o Rescaled the internal latent_heat variables in the control structure for
    MOM_surface_forcing_gfdl for improved dimensional consistency testing.
  o Removed the unused local variable PmE_adj in convert_IOB_to_fluxes().
  o Corrected the documented units or fixed spelling errors in several comments.
All answers and output are bitwise identical.
@codecov
Copy link
Copy Markdown

codecov Bot commented Nov 28, 2021

Codecov Report

Merging #14 (9eb7abd) into dev/gfdl (e218478) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           dev/gfdl      #14   +/-   ##
=========================================
  Coverage     29.17%   29.17%           
=========================================
  Files           240      240           
  Lines         71481    71481           
=========================================
  Hits          20852    20852           
  Misses        50629    50629           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e218478...9eb7abd. Read the comment docs.

@marshallward
Copy link
Copy Markdown
Member

Gaea regression: https://gitlab.gfdl.noaa.gov/ogrp/MOM6/-/pipelines/14235 ✔️

@marshallward marshallward merged commit a0248ef into NOAA-GFDL:dev/gfdl Nov 30, 2021
@Hallberg-NOAA Hallberg-NOAA added documentation Improvements or additions to documentation refactor Code cleanup with no changes in functionality or results labels Feb 1, 2022
@Hallberg-NOAA Hallberg-NOAA deleted the FMS_cap_rescaling branch March 25, 2022 12:43
marshallward pushed a commit that referenced this pull request Mar 12, 2026
In mom_cap.F90 rename module variable 'mype' to 'localPet'
Rename mom_ufs_trace_wrapper module to mom_cap_profiling
Add docstrings
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation refactor Code cleanup with no changes in functionality or results

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants