Bugfix: find_index in FMS2 infra#137
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## dev/gfdl #137 +/- ##
=========================================
Coverage 33.45% 33.45%
=========================================
Files 262 262
Lines 71385 71385
Branches 13323 13323
=========================================
Hits 23884 23884
Misses 43029 43029
Partials 4472 4472 Continue to review full report at Codecov.
|
adcroft
reviewed
Jun 2, 2022
This patch fixes two major bugs in the find_index function: * Incorrect variable declarations have been fixed * The API is now followed, and assumes that it's looking for .true. Obviously the previous patch had not been tested with the FMS2 infra or a compatible FMS library. This was has been checked against FMS 2022.02.
marshallward
force-pushed
the
find_index_bugfix
branch
from
94e14d1 to
a9e2bce
Compare
Member
Author
|
I removed the |
adcroft
approved these changes
Jun 2, 2022
Member
adcroft
left a comment
adcroft
left a comment
There was a problem hiding this comment.
Testing at https://gitlab.gfdl.noaa.gov/ogrp/MOM6/-/pipelines/15681 (although we now know the tests don't hit the code in question)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch fixes two major bugs in the find_index function:
Incorrect variable declarations have been fixed
The API is now followed, and assumes that it's looking for .true.
Obviously the previous patch had not been tested with the FMS2 infra or
a compatible FMS library. This was has been checked against FMS
2022.02.
I have also added an export statement to the .testing Makefile to allowfor configuration of the FMS branch within the CI test suite.