(*)Fix occasional bug with PFv_visc_rem diagnostic#128
Merged
marshallward merged 2 commits intoMay 28, 2022
Conversation
Corrected a bug that causes the bottom-drag filtered meridional acceleration diagnostics, like PFv_visc_rem, to erroneously be filled with all zeros unless one of the filtered u-point diagnostics is also enabled in the diag_table, and conversely could lead to segmentation fault if there are are only filtered u-point diagnostics. However, if at least one of both kinds of diagnostics are enabled, everything was already working as intended. Also changed a call to enabled_averaging into a call to enable_averages to avoid having to scale an argument. All solutions are bitwise identical, and in many cases the diagnostics are also unchanged.
Codecov Report
@@ Coverage Diff @@
## dev/gfdl #128 +/- ##
=========================================
Coverage 33.45% 33.45%
=========================================
Files 262 262
Lines 71384 71384
Branches 13323 13323
=========================================
Hits 23884 23884
Misses 43028 43028
Partials 4472 4472
Continue to review full report at Codecov.
|
Member
|
Gaea regression: https://gitlab.gfdl.noaa.gov/ogrp/MOM6/-/pipelines/15635 ✔️ |
marshallward
approved these changes
May 28, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Corrected a bug that causes the bottom-drag filtered meridional acceleration
diagnostics, like PFv_visc_rem, to erroneously be filled with all zeros unless
one of the filtered u-point diagnostics is also enabled in the diag_table, and
conversely could lead to segmentation fault if there are are only filtered
u-point diagnostics. However, if at least one of both kinds of diagnostics are
enabled, everything was already working as intended. Also changed a call to
enabled_averaging into a call to enable_averages to avoid having to scale an
argument. All solutions are bitwise identical, and in many cases the
diagnostics are also unchanged.