Fix data read for on-grid interpolation#124
Conversation
The wrong MOM_read_data interface was being used: a 2D slice of a 3D field was expected, but the interface for a 2D field was being called.
Codecov Report
@@ Coverage Diff @@
## dev/gfdl #124 +/- ##
============================================
- Coverage 33.48% 28.78% -4.71%
============================================
Files 262 249 -13
Lines 71362 72991 +1629
Branches 13310 0 -13310
============================================
- Hits 23898 21010 -2888
- Misses 42992 51981 +8989
+ Partials 4472 0 -4472
Continue to review full report at Codecov.
|
Hallberg-NOAA
left a comment
There was a problem hiding this comment.
I have looked into this code and the underlying routines that are called, and I agree that it makes sense. Assuming that it passes the TC and pipeline testing, this PR should be accepted once it reaches the front of the queue.
|
This has passed pipeline testing at https://gitlab.gfdl.noaa.gov/ogrp/MOM6/-/pipelines/15618. |
update MOM6 to its main 20231218 commit (disable FPEs)
The wrong
MOM_read_datainterface was being used: a 2D slice of a 3D field was expected, but the interface for a 2D field was being called.See mom-ocean#1567.