+Improve style compliance in config_src/external code#114
Merged
marshallward merged 4 commits intoMay 8, 2022
Conversation
Revised the stochastics-related code to bring it into closer alignment with the MOM6 style guide at https://github.com/mom-ocean/MOM6/wiki/Code-style-guide, and splitting config_src/external/stochastic_physics/stochastic_physics.F90 into two files (one of which is the new file get_stochy_pattern.F90) to respect the MOM6 convention that there is only one module per file. Also renamed two stochastics-related optional arguments to ePBL_column to better reflect what they do, and corrected a number of spelling errors in comments in the files that were being modified. All answers and output are bitwise identical, but there are some minor internal interface changes.
Revised the external/drifters code to bring it into closer alignment with the MOM6 style guide at https://github.com/mom-ocean/MOM6/wiki/Code-style-guide. This includes using standard syntax to document variable units, the addition of 'implicit none ; private', explicit public statements, and a licensing statement to the files that were missing one, and modifications to follow the MOM6 2-point indenting convention. All answers are bitwise identical.
Revised the external/ODA_hooks code to bring it into closer alignment with the MOM6 style guide at https://github.com/mom-ocean/MOM6/wiki/Code-style-guide. This includes using standard syntax to document variable units, the addition of 'implicit none ; private', and modifications to follow the MOM6 2-point indenting convention. All answers are bitwise identical.
Codecov Report
@@ Coverage Diff @@
## dev/gfdl #114 +/- ##
=========================================
Coverage 28.76% 28.77%
=========================================
Files 248 249 +1
Lines 72987 72968 -19
=========================================
- Hits 20996 20995 -1
+ Misses 51991 51973 -18
Continue to review full report at Codecov.
|
Member
|
Gaea regression: https://gitlab.gfdl.noaa.gov/ogrp/MOM6/-/pipelines/15432 ✔️ |
marshallward
approved these changes
May 8, 2022
marshallward
pushed a commit
that referenced
this pull request
Oct 25, 2023
* add optional run time info in nuopc cap. Author: Jun Wang
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is a series of commits that will bring the code in three of the
config_src/external directories into closer alignment with the MOM6 style guide
at https://github.com/mom-ocean/MOM6/wiki/Code-style-guide. There are also some
stochastics-related code changes in two parameterization/vertical files. All
answers are bitwise identical, but there are some minor changes to interfaces.
The commits in this PR include: