+Set thickness_units for use by deta_dt diagnostic#113
Merged
Conversation
Added a call to set thickness_units, which are used in the units description for the diagnostic deta_dt, which was recently added by NOAA-GFDL#99, but with an uninitialized variable being used for the units description. This changes contents of one entry in the MOM_available_diags, which will once again reproduce across runs and compilers. All solutions are bitwise identical.
Codecov Report
@@ Coverage Diff @@
## dev/gfdl #113 +/- ##
=========================================
Coverage 28.77% 28.77%
=========================================
Files 248 248
Lines 72954 72955 +1
=========================================
+ Hits 20991 20992 +1
Misses 51963 51963
Continue to review full report at Codecov.
|
Member
|
Gaea regression: https://gitlab.gfdl.noaa.gov/ogrp/MOM6/-/pipelines/15286 ✔️ 🟡 Fixes the units of |
marshallward
approved these changes
Apr 21, 2022
This was referenced May 16, 2022
marshallward
pushed a commit
that referenced
this pull request
Oct 25, 2023
update to MOM6 main 20230504 updating
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a call to set thickness_units, which are used in the units description
for the diagnostic deta_dt, which was recently added by
#99, but with an uninitialized variable
being used for the units description. This changes contents of one entry in the
MOM_available_diags, which will once again reproduce across runs and compilers.
All solutions are bitwise identical.